feat: replace nock with msw - #10
Merged
Merged
Conversation
The mock no longer owns an msw server: a second setupServer() instance silently breaks the one owned by the test suite, so instead the handlers are exposed through getHandlers()/registerHandlers() and registered on the server the test suite already has. msw becomes a peer dependency. Table lifecycle actions now wait for the table to leave CREATING / UPDATING / DELETING before responding. dynalite schedules that transition in a timer after its response callback, which was hidden by nock's slower response path but not by msw's.
🦋 Changeset detectedLatest commit: 8270bb4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mock no longer owns an msw server: a second setupServer() instance
silently breaks the one owned by the test suite, so instead the handlers
are exposed through getHandlers()/registerHandlers() and registered on
the server the test suite already has. msw becomes a peer dependency.
Table lifecycle actions now wait for the table to leave CREATING /
UPDATING / DELETING before responding. dynalite schedules that
transition in a timer after its response callback, which was hidden by
nock's slower response path but not by msw's.