Wire Table numeric and date tolerances end to end - #615
Merged
Merged
Conversation
Expose numeric and date/time tolerance in Table Compare options, Settings, and session settings; pass them through compare_table; mark in-tolerance cell diffs unimportant; and accept CSV-style text dates in the tolerance check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compare_tableintocompare_aligned_rows_with_options, and reportimportanton changed cells.Test plan
cargo test -p table-core --libcargo test -p open-diff-app compare_tablevitesttable session options + TableCompareViewpnpm typecheck(via pre-commit quality)