Phase 7 - Refactoring: Render actor creation#183
Draft
lorenzoberts wants to merge 6 commits into
Draft
Conversation
This commit moves the synchronous shell-backed render service out of infrastructure and into a top-level Render context. The existing RenderServiceApi behavior is preserved so App still renders patchset previews through the same service boundary while the code moves closer to the upcoming Render actor. This commit is part of the architecture's refactoring phase 7. Signed-off-by: lorenzoberts <lorenzobs@usp.br>
This commit introduces RenderPatchsetRequest and rendered preview DTOs for the Render context. The synchronous render service now accepts an explicit request payload and returns rendered preview entries instead of a raw Vec<String>, while App preserves the existing details preview behavior by converting the rendered strings into Ratatui text at the current boundary. This commit is part of the architecture's refactoring phase 7. Signed-off-by: lorenzoberts <lorenzobs@usp.br>
This commit introduces RenderMessage, RenderHandle, and RenderActor around the existing synchronous render service. The actor owns the render core, receives requests over mpsc, replies over oneshot, and runs shell-backed rendering through spawn_blocking while preserving the current fallback behavior. It also adds actor-level tests for patchset preview rendering, single patch rendering, and sequential requests through the same Render actor. This commit is part of the architecture's refactoring phase 7. Signed-off-by: lorenzoberts <lorenzobs@usp.br>
This commit wires App to RenderHandle for patchset preview rendering and starts RenderActor during application startup. Patchset details still build the same preview state, but the shell-backed rendering work now goes through the Render actor instead of a synchronous App service dependency. This commit is part of the architecture's refactoring phase 7. Signed-off-by: lorenzoberts <lorenzobs@usp.br>
This commit moves patchset details state assembly into PatchsetDetailsState::from_rendered_preview. App::open_patchset_details now focuses on orchestrating Lore and Render actor calls while the details screen state owns conversion from rendered preview strings into the existing Ratatui text payloads. This commit is part of the architecture's refactoring phase 7. Signed-off-by: lorenzoberts <lorenzobs@usp.br>
This commit moves the patch and cover renderer helpers out of App and into the Render context. Render no longer depends on App modules for preview rendering, and call sites now import renderer preferences from render_prefs directly. This commit completes the architecture's refactoring phase 7. Signed-off-by: lorenzoberts <lorenzobs@usp.br>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.