Skip to content

Move to the renamed @trinodb/trino-js-client - #8

Open
mosabua wants to merge 1 commit into
kuzho:mainfrom
simpligility:trino-js-client-rename
Open

Move to the renamed @trinodb/trino-js-client#8
mosabua wants to merge 1 commit into
kuzho:mainfrom
simpligility:trino-js-client-rename

Conversation

@mosabua

@mosabua mosabua commented Sep 3, 2026

Copy link
Copy Markdown

The Trino client was republished under the trinodb scope. Versions up to 0.2.9 shipped as the unscoped trino-client; the scoped @trinodb/trino-js-client starts at 0.3.0. The unscoped package is no longer maintained and will not receive further updates.

I am a Trino maintainer, and we are working through the downstream consumers of the client as part of that move.

Risk

Low. The declaration files of trino-client@0.2.9 and @trinodb/trino-js-client@0.3.2 are identical byte for byte, so this is a rename of the dependency and its require specifier with no API change. Your driver loads it dynamically via require, so the change is a single line in src/driver.ts plus the manifest and lockfile.

One thing worth a look

Your overrides block pins axios below what the client asks for:

"overrides": { "axios": "^1.7.9" }

0.3.2 declares axios@1.19.0, but the override keeps the resolution at 1.15.0. That still works — the client only uses axios.create().request() — but 1.19.0 carries several security fixes over 1.15.0, including the NO_PROXY loopback bypass from 1.16.0 and a raised form-data floor for GHSA-hmw2-7cc7-3qxx. I left the override alone since it is your call, but bumping or dropping it would pick those up.

For what it is worth, the next major of the client removes axios entirely in favour of native fetch, at which point the override stops mattering for this dependency.

Verification

I did not run your extension. Beyond the declaration comparison, I verified 0.3.2 against a real Trino coordinator using a harness built from the call patterns this driver uses. All checks pass. That harness now runs in the client's own CI (trinodb/trino-js-client#970).

The Trino client was republished under the trinodb scope. Versions up to
0.2.9 shipped as the unscoped trino-client, and the scoped name
@trinodb/trino-js-client starts at 0.3.0. The unscoped package is no
longer maintained and will not receive further updates.

This is a rename of the dependency and its require specifier. The
declaration files of 0.2.9 and 0.3.2 are identical byte for byte, so
there is no API change.

Note that the axios override in this package pins axios below what the
client declares. 0.3.2 asks for axios 1.19.0, while the "^1.7.9"
override keeps the resolution at 1.15.0. That still works, but it is
worth a look, since 1.19.0 carries several security fixes.

Assisted-by: Claude Code Opus 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant