Security: Unrestricted outbound URL fetch enables SSRF in parse() URL mode#559
Open
tuanaiseo wants to merge 1 commit intokurtmckee:mainfrom
Conversation
`feedparser.http.get()` performs `requests.get(url, ...)` on caller-provided URLs without host/IP allowlisting, private-network blocking, or scheme hardening at this layer. In services that pass user-controlled feed URLs to `feedparser.parse()`, this can be used to access internal metadata/services (SSRF), especially with default redirect following. Affected files: http.py Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
feedparser.http.get()performsrequests.get(url, ...)on caller-provided URLs without host/IP allowlisting, private-network blocking, or scheme hardening at this layer. In services that pass user-controlled feed URLs tofeedparser.parse(), this can be used to access internal metadata/services (SSRF), especially with default redirect following.Severity:
highFile:
feedparser/http.pySolution
Add a secure URL validation gate before fetching: restrict to
http/https, resolve DNS and block loopback/link-local/RFC1918 ranges, optionally enforce an allowlist, and disable or tightly control redirects (allow_redirects=Falseor re-validate each redirect target).Changes
feedparser/http.py(modified)Testing