Fix JSON Feed parser: use correct key for date_updated and prefer content_html#558
Open
danishashko wants to merge 1 commit intokurtmckee:mainfrom
Open
Fix JSON Feed parser: use correct key for date_updated and prefer content_html#558danishashko wants to merge 1 commit intokurtmckee:mainfrom
danishashko wants to merge 1 commit intokurtmckee:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs in the JSON Feed parser:
1. KeyError when parsing
date_updatedparse_entry()checks"date_updated" in e(correct per the JSON Feed spec) but then readse["date_modified"]which doesn't exist in JSON Feed. Every entry with adate_updatedfield raises aKeyError.2.
content_textsilently wins overcontent_htmlThe current
if/elifreturnscontent_textwhenever present, even ifcontent_htmlis also present. The JSON Feed 1.1 spec recommends HTML-capable clients prefercontent_html. Swapping the branches gives richer content by default and matches the spec intent.Both bugs are in
feedparser/parsers/json.py, no new imports needed.