Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes deprecated JSON serialization methods and updates test cases to directly serialize event data using byte arrays.
- Replace usage of deprecated methods with direct byte array serialization via ObjectMapper.
- Update test methods to reflect the new payload type and modify exception signatures accordingly.
- Remove deprecated methods from EventDataBuilder and EventData to streamline JSON handling.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/java/io/kurrent/dbclient/streams/MetadataTests.java | Updated payload serialization in metadata tests |
| src/test/java/io/kurrent/dbclient/samples/opentelemetry/Instrumentation.java | Updated JSON serialization with ObjectMapper |
| src/test/java/io/kurrent/dbclient/samples/appending_events/AppendingEvents.java | Updated event appending methods to use ObjectMapper serialization |
| src/main/java/io/kurrent/dbclient/EventDataBuilder.java | Removed deprecated JSON builder methods |
| src/main/java/io/kurrent/dbclient/EventData.java | Removed deprecated JSON builder method references |
Comments suppressed due to low confidence (3)
src/test/java/io/kurrent/dbclient/streams/MetadataTests.java:30
- The test payload type was changed from a HashMap to a byte array. Verify that the test assertions and downstream consumers are updated to handle this payload format.
byte[] payload = "data".getBytes();
src/test/java/io/kurrent/dbclient/samples/appending_events/AppendingEvents.java:72
- [nitpick] The TestEvent payload in the appendWithNoStream method was modified from 'some other value' to 'some value'. Confirm that this change is intentional to maintain the intended test scenario.
objectMapper.writeValueAsBytes(new TestEvent("2", "some value")))
src/test/java/io/kurrent/dbclient/samples/appending_events/AppendingEvents.java:102
- [nitpick] In the concurrency test, the event id for client one changed from '1' to '2', making both client events have the same identifier. Ensure this change is deliberate as it may affect the concurrency validation logic.
objectMapper.writeValueAsBytes(new TestEvent("2", "clientOne")))
YoEight
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.