Skip to content

Refactor dependencies and enhance CI with cargo-audit#31

Merged
kunlinglio merged 4 commits intomasterfrom
dev
Apr 26, 2026
Merged

Refactor dependencies and enhance CI with cargo-audit#31
kunlinglio merged 4 commits intomasterfrom
dev

Conversation

@kunlinglio
Copy link
Copy Markdown
Owner

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the blake3 dependency in favor of a std-based hash for config signatures, tightens Rust dependency feature flags to reduce build size, and updates CI to run cargo audit for dependency vulnerability scanning.

Changes:

  • Replace blake3 config signature hashing with a DefaultHasher-based implementation.
  • Refine serde and tokio dependency feature flags (and drop blake3) in Cargo.toml, updating Cargo.lock accordingly.
  • Add cargo audit runs to the GitHub Actions workflow and document the changes in the changelog.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/config.rs Switches config signature hashing away from blake3 to a std hasher helper.
Cargo.toml Removes blake3 and narrows serde/tokio features to reduce dependency footprint.
Cargo.lock Reflects dependency graph changes from removing blake3 and adjusting Tokio features.
CHANGELOG.md Notes dependency refactor and addition of cargo audit in CI.
.github/workflows/test.yaml Installs and runs cargo audit for both the root crate and the Zed extension.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Cargo.toml
Comment on lines +31 to +37
tokio = { version = "1.50.0", features = [
"fs",
"macros",
"rt",
"sync",
"io-std",
] }
Copy link

Copilot AI Apr 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The selected Tokio feature set drops rt-multi-thread, but the codebase uses #[tokio::test] in multiple modules and also has an optional #[tokio::main(flavor = "multi_thread")] entrypoint behind the multi-thread crate feature. #[tokio::test] defaults to the multi-thread runtime and will fail to compile without tokio/rt-multi-thread enabled (and the multi-thread feature will also fail when enabled). Consider either enabling rt-multi-thread (optionally gated behind the existing multi-thread feature), adding it via a dev-dependency-only Tokio feature set for tests, or updating tests to use #[tokio::test(flavor = "current_thread")].

Copilot uses AI. Check for mistakes.
@kunlinglio kunlinglio merged commit 995347e into master Apr 26, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants