Onset detector#117
Open
kunitoki wants to merge 9 commits into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #117 +/- ##
==========================================
+ Coverage 78.62% 78.69% +0.07%
==========================================
Files 614 627 +13
Lines 60956 61455 +499
==========================================
+ Hits 47927 48365 +438
- Misses 13029 13090 +61
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new log-spaced triangular filter bank for spectrogram processing and integrates onset detection and visualization into the audio file demo. The changes add a
FilterBankclass for dimensionality reduction of spectrograms, implement a new onset detection function, and extend the demo UI to display onset markers on the waveform. These improvements enhance the onset detection pipeline and provide visual feedback for detected onsets.DSP and Onset Detection Infrastructure:
FilterBankclass for log-spaced triangular filter banks, enabling perceptually-motivated dimensionality reduction of magnitude spectrograms. (modules/yup_dsp/onsets/yup_FilterBank.h[1]modules/yup_dsp/onsets/yup_FilterBank.cpp[2]ComplexFluxODF::compute) that leverages the filter bank and performs SuperFlux-style spectral differencing, including temporal and frequency masking for improved accuracy. (modules/yup_dsp/onsets/yup_OnsetDetectionFunction.cppmodules/yup_dsp/onsets/yup_OnsetDetectionFunction.cppR1-R217)Onset Detection and Visualization Integration:
AudioFileDemo, running in the background and updating the waveform with onset markers when complete. (examples/graphics/source/examples/AudioFileDemo.h[1] [2]AudioFileWaveformto support and render onset markers over the waveform, including methods to set and clear onset data and custom painting logic. (examples/graphics/source/examples/AudioFileDemo.h[1] [2] [3]