fix(ui): prevent AppCard crash on missing ingress and improve metrics display - #783
Open
Buddruggy wants to merge 1 commit into
Open
fix(ui): prevent AppCard crash on missing ingress and improve metrics display#783Buddruggy wants to merge 1 commit into
Buddruggy wants to merge 1 commit into
Conversation
Prevent pipeline page crashes when an app CR lacks addons or ingress.hosts, and prefer usage tables when some pods (e.g. addons) lack resource percentages. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a frontend crash on the pipeline apps page when an app CR is missing
addonsand/oringress.hosts, and improves AppCard metrics rendering for apps that include addon pods.Motivation / context
TypeError: Cannot read properties of undefined (reading 'length')app.addonsandapp.ingress.hostsalways exist, but apps returned from CRDs may omit them.Fixes #
Type of change
How Has This Been Tested?
Test Configuration:
Steps:
ingress.hosts(or withingress.enabled: false) → page no longer crashes.Checklist: