custom-plugin-monitor: Honor default condition status

[halaney]

Users can define a default status, but that's being stomped on currently. Let's honor what's defined, if defined correctly... otherwise continue to default to False and log a warning.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: halaney / name: Andrew Halaney (47db5e1)

[k8s-ci-robot]

Welcome @halaney!

It looks like this is your first PR to kubernetes/node-problem-detector 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/node-problem-detector has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @halaney. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: halaney
Once this PR has been reviewed and has the lgtm label, please assign klueska for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[halaney]

Hi! Can I get some review on this?

[DigitalVeer]

Currently none of the existing configs/*.json files with "plugin": "custom" actually set status on a condition. This means Status would now come in as "" which doesn't match True/False/Unknown, and by the new logic, go to the default branch and log a warning.

That means each CustomPluginMonitor condition without status will log a warning once at startup ( Condition "NTPProblem" has invalid initial status "", defaulting to "False". )

It may be worth honoring the default as such:

    case "":
        conditions[i].Status = types.False

[halaney]

hah, duh! thanks I'll make that change. We've been running this (plus my other open PRs) in our setup, but we use our own custom plugins and do set that.

[kubernetes-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: halaney
Once this PR has been reviewed and has the lgtm label, please assign klueska for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment