tests: add simple e2e test for guestbook#595
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@justinsb any particular reason for a gh workflow, rather than just hooking this up to prow? |
This highlights a few issues (out of date images, etc.), and will allow us to fix them with test coverage.
22ddd5c to
bc0fd84
Compare
I was just being lazy. Sent kubernetes/test-infra#37422 to add some prow. Created a single entrypoint though, rather than having to go back and forth to prow config e.g. if we add a test for guestbook-go. Should also let us share a cluster between examples, which should be slightly faster. |
This highlights a few issues (out of date images, etc.),
and will allow us to fix them with test coverage.