[k8s-keystone-auth] Preserve config after failed reload - #3159
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @immanuwell. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
41e19dd to
300b187
Compare
300b187 to
0d533d5
Compare
What this PR does / why we need it:
A malformed live policy or sync ConfigMap logs a parse error, but still replaces working config with empty or partial state
As a result, auth can start denying requests or syncing can silently stop
This keeps the last good config when parsing or validation fails. Valid reloads still work, and failures use the existing retry queue.
Which issue this PR fixes(if applicable):
N/A
Special notes for reviewers:
Repro:
policiesto{, or setsyncConfigto malformed YAML.Tests:
go test -race ./pkg/identity/keystonego test ./pkg/...make checkRelease note: