Skip to content

docs: Adding the Gateway inference support documentation for Nginx Ga… #1789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Nov 14, 2025
Merged

docs: Adding the Gateway inference support documentation for Nginx Ga… #1789

merged 10 commits into from
Nov 14, 2025
+237 −0

Conversation

@sindhushiv
Copy link
Contributor

@sindhushiv sindhushiv commented Oct 29, 2025

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Adds a v1.0.2 gateway inference support documentation for the Nginx Fabric Gateway.

Which issue(s) this PR fixes:

N/A

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Oct 29, 2025
@netlify
Copy link

netlify bot commented Oct 29, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 1fef95b
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/691622fbd0bb330008d3784d
😎 Deploy Preview https://deploy-preview-1789--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 29, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 29, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 29, 2025

Hi @sindhushiv. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 29, 2025
sjberman
sjberman reviewed Oct 30, 2025
View reviewed changes
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 3, 2025
salonichf5
salonichf5 reviewed Nov 3, 2025
View reviewed changes
salonichf5
salonichf5 reviewed Nov 3, 2025
View reviewed changes
salonichf5
salonichf5 reviewed Nov 3, 2025
View reviewed changes
danehans
danehans reviewed Nov 3, 2025
View reviewed changes
danehans
danehans reviewed Nov 3, 2025
View reviewed changes
danehans
danehans reviewed Nov 4, 2025
View reviewed changes
danehans
danehans reviewed Nov 4, 2025
View reviewed changes
danehans
danehans reviewed Nov 4, 2025
View reviewed changes
@kfswain
Copy link
Collaborator

kfswain commented Nov 4, 2025

Exciting stuff! Do you all have a conformance test report to include also?

@nirrozenbaum
Copy link
Contributor

nirrozenbaum commented Nov 4, 2025

Exciting stuff! Do you all have a conformance test report to include also?

@kfswain conformance PR has already been reviewed and merged 😃
see #1788

salonichf5
salonichf5 approved these changes Nov 5, 2025
View reviewed changes
Copy link

@salonichf5 salonichf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ahg-g
Copy link
Contributor

ahg-g commented Nov 7, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 7, 2025
@sindhushiv sindhushiv mentioned this pull request Nov 11, 2025
Closed
@sindhushiv
Copy link
Contributor Author

sindhushiv commented Nov 12, 2025

@ahg-g , @nirrozenbaum We’re still waiting for the approval, could someone please take a look when you get a chance? Thanks!

nirrozenbaum
nirrozenbaum reviewed Nov 13, 2025
View reviewed changes
nirrozenbaum
nirrozenbaum reviewed Nov 13, 2025
View reviewed changes
nirrozenbaum
nirrozenbaum reviewed Nov 13, 2025
View reviewed changes
nirrozenbaum
nirrozenbaum reviewed Nov 13, 2025
View reviewed changes
Copy link
Contributor

@nirrozenbaum nirrozenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sindhushiv I left just a few minor comments to updates links in the latest release section (point to latest release instead of main).

other than that, this PR looks great!

@sindhushiv
Copy link
Contributor Author

sindhushiv commented Nov 13, 2025

@nirrozenbaum , Addressed the comments. Thanks!

nirrozenbaum
nirrozenbaum approved these changes Nov 14, 2025
View reviewed changes
Copy link
Contributor

@nirrozenbaum nirrozenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks! 🙏🏼

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bjee19, nirrozenbaum, salonichf5, sindhushiv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2025
@k8s-ci-robot k8s-ci-robot merged commit 5b32ebc into kubernetes-sigs:main Nov 14, 2025
11 checks passed
rlakhtakia pushed a commit to rlakhtakia/gateway-api-inference-extension that referenced this pull request Nov 17, 2025
@sindhushiv @rlakhtakia
docs: Adding the Gateway inference support documentation for Nginx Ga… (
a8a854a 
kubernetes-sigs#1789)

* docs: Adding the Gateway inference support documentation for Nginx Gateway Fabric

* docs: Addressing comments

* docs: Addressed new set of comments

* docs: Fixed the helm command

* docs: Fixed cleaned up command

* docs: Fixed cleaned up command

* docs: Adding released version

* docs: Fixing the YAML files for test failure

* docs: Fixing the HTTP YAML file for test failure

* docs: Addressing the review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danehans danehans danehans left review comments

@nirrozenbaum nirrozenbaum nirrozenbaum approved these changes

@ahg-g ahg-g Awaiting requested review from ahg-g

+3 more reviewers

@sjberman sjberman sjberman left review comments

@bjee19 bjee19 bjee19 approved these changes

@salonichf5 salonichf5 salonichf5 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nirrozenbaum nirrozenbaum

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@sindhushiv @k8s-ci-robot @kfswain @nirrozenbaum @ahg-g @danehans @sjberman @bjee19 @salonichf5