chore: upgrade golangci-lint to version 2

[retornam]

Upgrade Golang to version to 1.25

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

It upgrades Golang version to 1.25 and golangci-lint to version 2

Which issue(s) this PR fixes:

Fixes #

Requirements:

• uses conventional commit messages
• includes documentation
• adds unit tests
• tested upgrade from previous version

Special notes for your reviewer:

Release note:

none

[k8s-ci-robot]

Hi @retornam. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: retornam
Once this PR has been reviewed and has the lgtm label, please assign jingxu97 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[andyzhangx]

/ok-to-test

[retornam]

/retest

[coveralls]

Pull Request Test Coverage Report for Build 19893705692

Details

• 15 of 18 (83.33%) changed or added relevant lines in 6 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 78.507%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/smb/controllerserver.go	2	3	66.67%
pkg/smb/nodeserver.go	9	11	81.82%

Totals
Change from base Build 19844492355:	0.0%
Covered Lines:	1125
Relevant Lines:	1433

---

💛 - Coveralls

[retornam]

/retest

[Copilot]

Pull Request Overview

This PR upgrades the project from Go version 1.24 to 1.25 and updates golangci-lint configuration to version 2, along with code quality improvements and formatting fixes.

• Updates Go version from 1.24 to 1.25 across all GitHub workflow files
• Upgrades golangci-lint from v1.64 to v2.4.0 with new configuration format
• Applies various code formatting and style improvements identified by the updated linter

Reviewed Changes

Copilot reviewed 36 out of 39 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
go.mod	Updates Go version from 1.24 to 1.25
.golangci.yml	Upgrades golangci-lint configuration to version 2 format
.github/workflows/*.yaml	Updates Go versions in CI workflows from older versions to 1.25
pkg/smb/*.go	Fixes octal literals, variable declarations, error messages, and imports formatting
test/e2e/*.go	Improves import formatting and API usage patterns
release-tools/filter-junit.go	Updates file permissions to use octal literal format

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[andyzhangx]

not sure whether it's an identical change, is this part of golint change? it seems not

[retornam]

it is. I'll revert if you prefer the earlier version and add an ignore.

[andyzhangx]

pls revert it, thx

[ddl-retornam]

@andyzhangx sorry for the delay. done

[retornam]

@andyzhangx can you please review this.

[retornam]

/retest-required

[andyzhangx]

/retest

[andyzhangx]

@retornam can you use golang 1.25.5 to build in trivy action?

┌─────────┬────────────────┬──────────┬────────┬───────────────────┬─────────────────┬────────────────────────────────────────────────────────────┐
│ Library │ Vulnerability  │ Severity │ Status │ Installed Version │  Fixed Version  │                           Title                            │
├─────────┼────────────────┼──────────┼────────┼───────────────────┼─────────────────┼────────────────────────────────────────────────────────────┤
│ stdlib  │ CVE-2025-61727 │ UNKNOWN  │ fixed  │ v1.25.4           │ 1.24.11, 1.25.5 │ Improper application of excluded DNS name constraints when │
│         │                │          │        │                   │                 │ verifying wildcard names in...                             │
│         │                │          │        │                   │                 │ https://avd.aquasec.com/nvd/cve-2025-61727                 │
│         ├────────────────┤          │        │                   │                 ├────────────────────────────────────────────────────────────┤
│         │ CVE-2025-61729 │          │        │                   │                 │ Within HostnameError.Error(), when constructing an error   │

[andyzhangx]

  Error: pkg/smb/nodeserver.go:37:2: SA1019: "golang.org/x/net/context" is deprecated: Use the standard library context package instead. (staticcheck)
  	"golang.org/x/net/context"
  	^
  Error: pkg/smb/smb_common_linux.go:50:17: QF1012: Use fmt.Fprintf(...) instead of Write([]byte(fmt.Sprintf(...))) (staticcheck)
  			if _, err := file.Write([]byte(fmt.Sprintf("%s\n", option))); err != nil {
  			             ^

[retornam]

/retest-required

[retornam]

@andyzhangx i fixed the golangci-lint errors by ignoring that file. The windows test failures seem to be that it cant find the service account token, i'd like some guidance on how to fix as I dont have access to a windows machine to run tests on

[k8s-ci-robot]

@retornam: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-csi-driver-smb-e2e-windows-2022	98d7b5b	link	false	/test pull-csi-driver-smb-e2e-windows-2022
pull-csi-driver-smb-verify	ddb5af6	link	true	/test pull-csi-driver-smb-verify
pull-csi-driver-smb-e2e-windows-2019	ddb5af6	link	false	/test pull-csi-driver-smb-e2e-windows-2019

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.