You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the no_proxy configuration is reset after it is configured due to a duplicate self.no_proxy = None line being added in the autogenerated file configuration.py
Initially the thought was the script insert_proxy_config.sh was applying this duplicate. However, when this script is run on the openapi generated code, configuration.py looks correct.
Looking at the full release.sh script, there is another script applying proxy settings by cherry-picking commit 95a893c in apply-hotfixes.sh. This commit adds self.no_proxy = None. When applied after insert_proxy_config.sh this results in the duplicate lines and the no_proxy becoming None.
Changing the order of the applied scripts in release.sh so that insert_proxy_config.sh is run afterapply-hotfixes.sh resolves the problem because insert_proxy_config.sh is able to detect the existing self.no_proxy = None and insert it's code correctly without resetting the no_proxy.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
approvedIndicates a PR has been approved by an approver from all required OWNERS files.cncf-cla: yesIndicates the PR's author has signed the CNCF CLA.kind/bugCategorizes issue or PR as related to a bug.lgtm"Looks good to me", indicates that a PR is ready to be merged.release-note-noneDenotes a PR that doesn't merit a release note.size/XSDenotes a PR that changes 0-9 lines, ignoring generated files.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Currently the
no_proxyconfiguration is reset after it is configured due to a duplicateself.no_proxy = Noneline being added in the autogenerated file configuration.pyInitially the thought was the script insert_proxy_config.sh was applying this duplicate. However, when this script is run on the openapi generated code,
configuration.pylooks correct.Looking at the full release.sh script, there is another script applying proxy settings by cherry-picking commit 95a893c in apply-hotfixes.sh. This commit adds
self.no_proxy = None. When applied afterinsert_proxy_config.shthis results in the duplicate lines and the no_proxy becoming None.Changing the order of the applied scripts in
release.shso thatinsert_proxy_config.shis run afterapply-hotfixes.shresolves the problem becauseinsert_proxy_config.shis able to detect the existingself.no_proxy = Noneand insert it's code correctly without resetting the no_proxy.Which issue(s) this PR fixes:
Fixes #2460
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: