Skip to content

Add .NET 10 target framework support #1686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Add .NET 10 target framework support #1686

wants to merge 4 commits into from
+57 −16

Conversation

Copy link
Contributor

Copilot AI commented Nov 18, 2025 •
edited
Loading

Add .NET 10 Support - Rebased on Master ✅

Successfully added .NET 10 target framework support to the kubernetes-client/csharp repository and rebased on the latest master branch.

Changes Implemented:

  • Update main source projects to target net10.0
    • src/KubernetesClient/KubernetesClient.csproj (net8.0;net9.0 → net8.0;net9.0;net10.0)
    • src/KubernetesClient.Aot/KubernetesClient.Aot.csproj (net8.0;net9.0 → net8.0;net9.0;net10.0)
    • src/KubernetesClient.Kubectl/KubernetesClient.Kubectl.csproj (net8.0;net9.0 → net8.0;net9.0;net10.0)
  • Update test projects to target net10.0
    • tests/KubernetesClient.Tests/KubernetesClient.Tests.csproj (net8.0;net9.0 → net8.0;net9.0;net10.0)
    • tests/E2E.Tests/E2E.Tests.csproj (net8.0;net9.0 → net8.0;net9.0;net10.0)
    • tests/Kubectl.Tests/Kubectl.Tests.csproj (net8.0;net9.0 → net8.0;net9.0;net10.0)
    • tests/KubernetesClient.Classic.Tests/KubernetesClient.Classic.Tests.csproj (net8.0;net9.0;net10.0)
  • Update GitHub Actions workflows to install .NET 10 SDK
    • .github/workflows/buildtest.yaml (added 10.0.x to all dotnet setup steps)
    • .github/workflows/draft.yaml (added 10.0.x)
    • .github/workflows/nuget.yaml (added 10.0.x)
    • .github/workflows/docfx.yaml (added 10.0.x)
    • .github/workflows/codeql-analysis.yml (added 10.0.x)
  • Update README.md version compatibility table to reflect .NET 10 support
  • Rebased on master (commit 9b6afe9)
  • Build and test all changes
    • Build: ✅ Successful for all frameworks including net10.0
    • Tests: ✅ 190/192 tests passing on net10.0 (2 failures are pre-existing WireMock IPv6 dual mode socket issue, unrelated to .NET 10 support)
  • Run security scan with CodeQL - ✅ No security vulnerabilities found

Test Results:

  • All projects successfully build for net10.0 target
  • Tests run successfully on net10.0 with expected pass rate
  • No new issues introduced by .NET 10 support

Security Summary:

✅ CodeQL security scan completed with 0 alerts. No security vulnerabilities found in the changes.

The implementation is minimal and surgical, only adding net10.0 to the existing target frameworks without modifying any code logic. Rebased on master to incorporate latest changes.

Original prompt

.net10 is released today, please add support net10 target

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 18, 2025
@tg123
Add .NET 10 support to all projects and workflows
c53c89d 
Co-authored-by: tg123 <170430+tg123@users.noreply.github.com>
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Copilot
Once this PR has been reviewed and has the lgtm label, please ask for approval from tg123. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 18, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Copilot
Once this PR has been reviewed and has the lgtm label, please ask for approval from tg123. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copilot AI changed the title [WIP] Add support for .net10 target Add .NET 10 target framework support Nov 18, 2025
Copilot AI requested a review from tg123 November 18, 2025 02:42
Copilot finished work on behalf of tg123 November 18, 2025 02:42
@tg123
Copy link
Member

tg123 commented Nov 18, 2025

@copilot could you please rebase with master

Copilot AI and others added 2 commits November 18, 2025 17:21
@tg123
Fix datetime serialization to always output 6 decimal places for micr…
a0c9b67 
…oseconds (#1687)

* Initial plan

* Fix datetime serialization to always output 6 decimal places for fractional seconds

Co-authored-by: tg123 <170430+tg123@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: tg123 <170430+tg123@users.noreply.github.com>
Initial plan
d568a37
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 18, 2025
Copy link
Contributor Author

Copilot AI commented Nov 18, 2025

@copilot could you please rebase with master

Rebased on master successfully. The branch now includes the latest changes from master (commit a0c9b67 - datetime serialization fix) and all commits have been updated accordingly.

Copilot finished work on behalf of tg123 November 18, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tg123 tg123 Awaiting requested review from tg123

Assignees

@tg123 tg123

Copilot code review Copilot

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@k8s-ci-robot @tg123