Skip to content

ci(pvc): upgrade Go to 1.24 for pvcviewer-controller #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: notebooks-v1
Choose a base branch
from
Open

ci(pvc): upgrade Go to 1.24 for pvcviewer-controller #734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pvcviewer_controller_unit_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Install Go
uses: actions/setup-go@v5
with:
go-version: "1.22.2"
go-version-file: 'components/pvcviewer-controller/go.mod'
check-latest: true

- name: Run unit tests
Expand Down
4 changes: 2 additions & 2 deletions components/pvcviewer-controller/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Build the manager binary
ARG GOLANG_VERSION=1.22.2
ARG GOLANG_VERSION=1.24
FROM golang:${GOLANG_VERSION} as builder

WORKDIR /workspace
Expand All @@ -16,7 +16,7 @@ COPY pvcviewer-controller/api/ api/
COPY pvcviewer-controller/controllers/ controllers/

# Build
RUN CGO_ENABLED=0 GOOS=linux GO111MODULE=on go build -a -mod=mod -o manager main.go
RUN CGO_ENABLED=0 GOOS=linux go build -a -o manager main.go

# Use distroless as minimal base image to package the manager binary
# Refer to https://github.com/GoogleContainerTools/distroless for more details
Expand Down
2 changes: 1 addition & 1 deletion components/pvcviewer-controller/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/kubeflow/notebooks/components/pvcviewer-controller

go 1.22.2
go 1.24

require (
github.com/go-logr/logr v1.4.1
Expand Down
Loading