Skip to content

Conversation

@obaydullahmhs
Copy link
Member

No description provided.

Signed-off-by: obaydullahmhs <obaydullah@appscode.com>
@github-actions
Copy link

github-actions bot commented Jan 17, 2026

Visit the preview URL for this PR (updated for commit 591dfb5):

https://kubedb-v2-hugo--pr840-reconfig-vddkg1cf.web.app

(expires Tue, 27 Jan 2026 15:54:38 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 0f29ae8ae0bd54a99bf2b223b6833be47acd5943

Signed-off-by: Bonusree <bonusree@appscode.com>
Signed-off-by: Bonusree <bonusree@appscode.com>
@gitguardian
Copy link

gitguardian bot commented Jan 20, 2026

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
25884160 Triggered Generic Password f670872 docs/guides/clickhouse/concepts/clickhouse.md.bak View secret
25884161 Triggered Username Password f670872 docs/guides/cassandra/concepts/cassandra.md.bak View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

obaydullahmhs and others added 3 commits January 20, 2026 17:20
Signed-off-by: Bonusree <bonusree@appscode.com>
Signed-off-by: Bonusree <bonusree@appscode.com>
Copy link
Member

@ArnobKumarSaha ArnobKumarSaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats remaining here ?

Comment on lines -11 to +12
configSecret:
name: new-ch-custom-config
configuration:
secretName: new-ch-custom-config
Copy link
Member

@Neaj-Morshad-101 Neaj-Morshad-101 Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpsRequest's Configuration API was not updated. So keep the configSecret field as it is.
Only the restart field was added. Add the description of this field in the concepts section.

spec:
  configuration:
    restart: auto | true | false

Signed-off-by: Bonusree <bonusree@appscode.com>
Signed-off-by: Bonusree <bonusree@appscode.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants