-
Notifications
You must be signed in to change notification settings - Fork 53
Update .spec.configuration API changes #840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: obaydullahmhs <obaydullah@appscode.com>
|
Visit the preview URL for this PR (updated for commit 591dfb5): https://kubedb-v2-hugo--pr840-reconfig-vddkg1cf.web.app (expires Tue, 27 Jan 2026 15:54:38 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 0f29ae8ae0bd54a99bf2b223b6833be47acd5943 |
Signed-off-by: Bonusree <bonusree@appscode.com>
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 25884160 | Triggered | Generic Password | f670872 | docs/guides/clickhouse/concepts/clickhouse.md.bak | View secret |
| 25884161 | Triggered | Username Password | f670872 | docs/guides/cassandra/concepts/cassandra.md.bak | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Signed-off-by: Bonusree <bonusree@appscode.com>
Signed-off-by: Bonusree <bonusree@appscode.com>
ArnobKumarSaha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whats remaining here ?
| configSecret: | ||
| name: new-ch-custom-config | ||
| configuration: | ||
| secretName: new-ch-custom-config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OpsRequest's Configuration API was not updated. So keep the configSecret field as it is.
Only the restart field was added. Add the description of this field in the concepts section.
spec:
configuration:
restart: auto | true | false
Signed-off-by: Bonusree <bonusree@appscode.com>
Signed-off-by: Bonusree <bonusree@appscode.com>
No description provided.