Assert there is exactly one, rather than counting to one - #158
Merged
Conversation
MSTEST0037 on the replacement test: Assert.ContainsSingle says what the assertion means, and reports which entries it found when there is more than one - which is the failure this test exists to catch, a registration that duplicated instead of replacing. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AhoPJ5AbxP8QEBNxPQYEPk
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The one finding SonarCloud left on #157 after its gate passed, in the test that PR added.
MSTEST0037onGeneratorRegistryTests.RegisteringTwiceReplaces:ContainsSinglesays what the assertion means, and it reports which entries it found when there is more than one — which is precisely the failure this test exists to catch, a registration that duplicated instead of replacing.AreEqual(1, …)would only say "expected 1, was 2".376 tests pass, 0 warnings, 0 errors.
🤖 Generated with Claude Code
https://claude.ai/code/session_01AhoPJ5AbxP8QEBNxPQYEPk
Generated by Claude Code