Add subsystem channel request support (RFC 4254 §6.5)#98
Merged
kruton merged 2 commits intokruton:mainfrom Apr 4, 2026
Merged
Conversation
Add requestSubsystem(name) to SshSession interface and SessionChannel implementation, enabling subsystem invocation (e.g. SFTP) on session channels. Follows the same pattern as requestShell(). Integration tests verify: - SFTP subsystem opens and responds to SSH_FXP_INIT with SSH_FXP_VERSION - Unknown subsystem names are rejected by the server
9cdc231 to
0cac9f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
requestSubsystem(name: String): Booleanto theSshSessioninterface andSessionChannelimplementation, enabling subsystem invocation (e.g. SFTP) on session channels.This is a prerequisite for SFTP support (discussed in #96). Follows the same pattern as
requestShell().Changes
SshSession.kt— addedrequestSubsystem(name: String): Booleanto the interfaceSessionChannel.kt— implementation usingChannelRequestSubsystemprotocol messageSshClientIntegrationTest.kt— two integration tests:Test plan
./gradlew :sshlib:test— integration tests pass against OpenSSH testcontainer