Repository navigation
fix(web): menus and dialogs no longer shift the page left (web 0.63.1) - #637
Merged
Merged
Conversation
The html element keeps a stable scrollbar gutter, and Radix's scroll lock (react-remove-scroll) also adds a body margin the width of the scrollbar, so the page moved left whenever a menu or dialog opened. Zero that margin while the lock is on. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
…ported Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Opening the site switcher (or any Radix menu or dialog) moved the whole page a few pixels to the left.
htmlhasscrollbar-gutter: stable, so the scrollbar's space is always reserved. Radix locks scrolling with react-remove-scroll, which also setsmargin-right: <scrollbar width>px !importantonbodyto make up for the hidden scrollbar. With the gutter already in place, that margin shifted the page a second time (10px margin, 5px shift of centred content in a local check).The fix sets
body[data-scroll-locked] { margin-right: 0 !important; }in the base layer. An!importantdeclaration in a cascade layer beats the library's unlayered!important, so specificity and injection order do not matter.Testing
Web 0.63.1 with a changelog entry.
🤖 Generated with Claude Code