Skip to content

fix: pass masterConsentsOrigin as URL param and merge duplicate integrations key#193

Merged
dangrondahl merged 1 commit intomainfrom
fix/termly-consent-sync
Apr 30, 2026
Merged

fix: pass masterConsentsOrigin as URL param and merge duplicate integrations key#193
dangrondahl merged 1 commit intomainfrom
fix/termly-consent-sync

Conversation

@dangrondahl
Copy link
Copy Markdown
Contributor

Summary

  • termly.js: masterConsentsOrigin was set as a data- attribute instead of a URL query parameter, so Termly never read it and consent sync between www.kosli.com and docs.kosli.com did not work. Now passed as &masterConsentsOrigin=https://www.kosli.com on the script src URL per Termly docs.
  • docs.json: Two duplicate integrations keys — the second (mixpanel) silently overwrote the first (cookies), dropping the cookie consent gating for Mintlify telemetry. Merged into a single key.

Test plan

  • Deploy to docs.kosli.com
  • Accept cookies on www.kosli.com
  • Open docs.kosli.com in a new tab — banner should NOT appear (consent synced)
  • Open docs.kosli.com in incognito — banner SHOULD appear

…rations key

The masterConsentsOrigin was set as a data attribute instead of a URL
query parameter, so Termly never read it and consent sync between
www.kosli.com and docs.kosli.com did not work. Also merges the two
duplicate `integrations` keys in docs.json — the second silently
overwrote the first, dropping the cookies config.
@dangrondahl dangrondahl requested a review from a team as a code owner April 30, 2026 15:33
@mintlify
Copy link
Copy Markdown
Contributor

mintlify Bot commented Apr 30, 2026

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
kosli 🟢 Ready View Preview Apr 30, 2026, 3:34 PM

@dangrondahl dangrondahl merged commit 8924ba9 into main Apr 30, 2026
4 checks passed
@dangrondahl dangrondahl deleted the fix/termly-consent-sync branch April 30, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants