Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes support for PHP 8.0 builds and upgrades the h5bp/server-configs-nginx dependency from version 3.3.0 to 5.0.1 across all remaining nginx-based Docker images.
- Removes all PHP 8.0 build variants (swoole, swoole-prod, swoole-nginx, swoole-nginx-prod) from the build configuration
- Updates h5bp/server-configs-nginx dependency from 3.3.0 to 5.0.1 for all nginx-based images
- Reorganizes documentation to classify PHP 8.0 as a legacy version
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| fwd-template.json | Removed all four 8.0 build configurations (8.0-swoole, 8.0-swoole-prod, 8.0-swoole-nginx, 8.0-swoole-nginx-prod) |
| README.md | Reorganized version documentation to move 8.0 to "Legacy Versions" section with consolidated links |
| template/Dockerfile-nginx.blade.php | Updated h5bp/server-configs-nginx version from 3.3.0 to 5.0.1 in the template |
| 8.{1,2,3,4}-swoole-nginx/Dockerfile | Updated h5bp/server-configs-nginx version from 3.3.0 to 5.0.1 in all nginx variant Dockerfiles |
| 8.{1,2,3,4}-swoole-nginx-prod/Dockerfile | Updated h5bp/server-configs-nginx version from 3.3.0 to 5.0.1 in all nginx production variant Dockerfiles |
| 8.0-swoole*/Dockerfile | Deleted all PHP 8.0 Dockerfiles |
| 8.0-swoole-nginx*/supervisor.conf | Deleted supervisor configuration files for 8.0 nginx variants |
| 8.0-swoole-nginx*/entrypoint | Deleted entrypoint scripts for 8.0 nginx variants |
| 8.0-swoole-nginx*/default.tmpl | Deleted nginx configuration templates for 8.0 nginx variants |
| .github/workflows/ci-cd.yml | Removed '8.0-swoole' from the CI/CD build matrix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.