Repository navigation
Fix the panel at the instance's address without a trailing slash - #21
Merged
Merged
Conversation
Under a path base, a signed-in user got 500 at the instance's address without the trailing slash (kododo.dev/polyglot/demo); with it, the panel opened. Way.Shell 2.1.1 handles the empty request path there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 0.6.0, under a path base, a signed-in user got 500 at the instance's address without the trailing slash (
kododo.dev/polyglot/demo). With the slash, the panel opened. The cause was in Way.Shell 2.1.0: the empty request path at the panel in the root (WayShell#2).UnderPathBase_CanSignInAndUseEditoralso opens the panel at/polyglot/and/polyglot. The second check failed on 2.1.0.119 tests.