Repository navigation
Update CultureWay to 2.0.0 - #18
Merged
Merged
Conversation
The editor runs in Way.Shell: Polyglot's title, menu links and signed-in user are set on ShellOptions (AddWayShell) instead of the obsolete EditorOptions, which keeps only the import limit and who may change languages. Without sign-in the editor allows anonymous access, since outside Development it otherwise answers 403. Polyglot's pages share the theme with the editor under Way.Shell's key (way-shell:theme).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CultureWay 2.0.0 runs its editor in Way.Shell.
AddWayShell(...)onShellOptions;EditorOptionskeeps the import limit and who may change languages. The oldEditorOptionsfields are obsolete in CultureWay 2.0.Polyglot:Auth:Enabled=false) the editor callsAllowAnonymous(): outside Development Way.Shell otherwise answers 403. New test for it.way-shell:theme), so the theme stays the same between the pages and the editor.GetEditorSettings.Checked locally: 119 tests; the published app in demo mode under
/polyglot/demoin Chrome, Edge, Firefox and WebKit (sign-in, menu, user, theme both ways).