Repository navigation
bun run icon: save an app's icon from a link or its download; fill 126 missing icons - #36
Merged
Merged
Conversation
…; fill 126 missing icons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
bun run icon <slug> <link> [--credit …] [--license …](scripts/icon.ts, macOS only). The link can be an icon file (PNG, JPEG,.icns; a GitHub file page works) or the app's official.dmg/.zip, from which the icon the app itself declares is used (Icon Composer / asset-catalog icons are rendered by macOS). It saves a 256 pxassets/icon.pngand records the link, credit and license inassets, keeping the record's YAML style. It refuses images that are not square, smaller than 128 px, or macOS's generic app icon, and leaves files untouched on failure. Documented in CONTRIBUTING.md.docs/VERIFICATION.mdentry.Rebased onto
mainafter #35: four records (BeagleEditor Legacy, EME, GitAhead, Spotifly) had new descriptions and sources there; their rewrites are kept and the icon lines added. Also restores a missing blank line between twodocs/VERIFICATION.mdentries.Verification
bun run validate(1,869 apps),bun run sync(no changes),bun run check:generated,bun test(24),bun run check(0 errors),bun run build(2,061 pages),bun run check:links(180,981 links),bun run check:homebrew. The command was smoke-tested on a PNG page link, an.icns, a DMG with an Icon Composer icon, a non-square PNG, a non-https link and an unknown slug.Undo
Revert this commit.