Skip to content

fix: use %w instead of %v for error wrapping in fmt.Errorf#3946

Open
Kritagya123611 wants to merge 1 commit into
knative:mainfrom
Kritagya123611:feat/my-changes
Open

fix: use %w instead of %v for error wrapping in fmt.Errorf#3946
Kritagya123611 wants to merge 1 commit into
knative:mainfrom
Kritagya123611:feat/my-changes

Conversation

@Kritagya123611

Copy link
Copy Markdown

Changes

Use %w verb instead of %v in fmt.Errorf calls to preserve error chains, enabling errors.Is and errors.As to match wrapped errors correctly.

Affected packages:

  • pkg/config
  • pkg/docker
  • pkg/functions
  • pkg/k8s
  • pkg/keda
  • pkg/knative
  • pkg/pipelines/tekton
  • pkg/testing
  • hack/cmd/components

/kind cleanup

Release Note

NONE

Docs

NONE

Preserve error chains across the codebase so that errors.Is/As
work correctly with wrapped errors.
@knative-prow knative-prow Bot added the kind/cleanup Cleanup label Jul 14, 2026
@linux-foundation-easycla

linux-foundation-easycla Bot commented Jul 14, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: Kritagya123611 / name: Kritagya123611 (fa27053)

@knative-prow

knative-prow Bot commented Jul 14, 2026

Copy link
Copy Markdown

Welcome @Kritagya123611! It looks like this is your first PR to knative/func 🎉

@knative-prow knative-prow Bot added size/L 🤖 PR changes 100-499 lines, ignoring generated files. needs-ok-to-test 🤖 Needs an org member to approve testing labels Jul 14, 2026
@knative-prow

knative-prow Bot commented Jul 14, 2026

Copy link
Copy Markdown

Hi @Kritagya123611. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow Bot requested review from dsimansk and jrangelramos July 14, 2026 15:13
@knative-prow

knative-prow Bot commented Jul 14, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Kritagya123611
Once this PR has been reviewed and has the lgtm label, please assign dprotaso for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Kritagya123611

Copy link
Copy Markdown
Author

Hi @dsimansk and @jrangelramos

Just a friendly reminder about this PR when you have a chance. I'd really appreciate any feedback. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Cleanup needs-ok-to-test 🤖 Needs an org member to approve testing size/L 🤖 PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant