Skip to content

fix: use taskRunTemplate for podTemplate in Tekton v1 PipelineRuns #3871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Itx-Psycho0 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use taskRunTemplate for podTemplate in Tekton v1 PipelineRuns #3871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions pkg/pipelines/tekton/templates_pack.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,11 +125,12 @@ spec:
value: "{{.Commit}}"
pipelineRef:
name: {{.PipelineName}}
podTemplate:
securityContext:
runAsUser: 1001
runAsGroup: 0
fsGroup: 1002
taskRunTemplate:
podTemplate:
securityContext:
runAsUser: 1001
runAsGroup: 0
fsGroup: 1002
workspaces:
- name: source-workspace
persistentVolumeClaim:
Expand Down Expand Up @@ -190,11 +191,12 @@ spec:
{{end}}
pipelineRef:
name: {{.PipelineName}}
podTemplate:
securityContext:
runAsUser: 1001
runAsGroup: 0
fsGroup: 1002
taskRunTemplate:
podTemplate:
securityContext:
runAsUser: 1001
runAsGroup: 0
fsGroup: 1002
workspaces:
- name: source-workspace
persistentVolumeClaim:
Expand Down
22 changes: 12 additions & 10 deletions pkg/pipelines/tekton/templates_s2i.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,11 +136,12 @@ spec:
value: "{{.Commit}}"
pipelineRef:
name: {{.PipelineName}}
podTemplate:
securityContext:
runAsUser: 1001
runAsGroup: 0
fsGroup: 1002
taskRunTemplate:
podTemplate:
securityContext:
runAsUser: 1001
runAsGroup: 0
fsGroup: 1002
workspaces:
- name: source-workspace
persistentVolumeClaim:
Expand Down Expand Up @@ -208,11 +209,12 @@ spec:
value: {{.TlsVerify}}
pipelineRef:
name: {{.PipelineName}}
podTemplate:
securityContext:
runAsUser: 1001
runAsGroup: 0
fsGroup: 1002
taskRunTemplate:
podTemplate:
securityContext:
runAsUser: 1001
runAsGroup: 0
fsGroup: 1002
workspaces:
- name: source-workspace
persistentVolumeClaim:
Expand Down
9 changes: 7 additions & 2 deletions pkg/pipelines/tekton/templates_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,9 +376,14 @@ func Test_PipelineRunHasPodTemplateSecurityContext(t *testing.T) {

contentStr := string(content)

// Verify podTemplate is present
// Verify taskRunTemplate is present (Tekton v1 API requirement)
if !strings.Contains(contentStr, "taskRunTemplate:") {
t.Error("taskRunTemplate not found in generated PipelineRun")
}

// Verify podTemplate is nested under taskRunTemplate
if !strings.Contains(contentStr, "podTemplate:") {
t.Error("podTemplate not found in generated PipelineRun")
t.Error("podTemplate not found in taskRunTemplate")
}

// Verify securityContext is present
Expand Down