Fix jobsink status Location paths for slashy event metadata

[immanuwell]

Proposed Changes

• escape source and id when jobsink builds the status Location header
• unescape them on GET, so the status URL round-trips again
• add unit tests for normal values and slash-heavy values

Repro

1. Create a JobSink.
2. Send an event with source=https://example.com/sources/my/source.
3. Read the Location header from the POST response.
4. GET that URL.

Before this patch, the GET can return 400 because raw / in source turn into extra path segments. Pretty normal input, the status URL just goes sideways a bit.

Pre-review Checklist

• At least 80% unit test coverage
• E2E tests for any new behavior
• Docs PR for any user-facing impact
• Spec PR for any new API feature
• Conformance test for any change to the spec

Release Note

Fixed `jobsink` status `Location` URLs for events whose CloudEvents `source` or `id` contain `/`.

Docs

knative/docs#6651

[knative-prow]

Welcome @immanuwell! It looks like this is your first PR to knative/eventing 🎉

[knative-prow]

Hi @immanuwell. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[creydr]

Thanks a lot for the fix @immanuwell

/lgtm

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, immanuwell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [creydr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[creydr]

/ok-to-test