fix: dynamically calculate toast cleanup timeout from CSS transition …#88
Open
nolostra wants to merge 1 commit intoknadh:masterfrom
Open
fix: dynamically calculate toast cleanup timeout from CSS transition …#88nolostra wants to merge 1 commit intoknadh:masterfrom
nolostra wants to merge 1 commit intoknadh:masterfrom
Conversation
nolostra
force-pushed
the
fix/toast-transition-timeout
branch
3 times, most recently
from
ef23016 to
40de9fa
Compare
…duration Fixes knadh#87 Replace hardcoded 200ms timeout with dynamic calculation that reads the transition duration from computed styles. This ensures the timeout always matches the CSS transition duration, even if it changes. - Calculate duration after setting data-exiting attribute - Handle multiple transition durations by taking the maximum - Fallback to 200ms if calculation fails - Force reflow to ensure styles are applied before reading
nolostra
force-pushed
the
fix/toast-transition-timeout
branch
from
40de9fa to
6853df9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #89
Replace hardcoded 200ms timeout with dynamic calculation that reads the transition duration from computed styles. This ensures the timeout always matches the CSS transition duration, even if it changes.