Fail fast when production SSH is unreachable - #117
Conversation
|
Warning Review limit reached
Next review available in: 54 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
📝 WalkthroughWalkthroughBoth deployment workflows now use explicit SSH connection settings, identify registry-login steps, and restrict temporary credential cleanup to successful registry authentication. The docs workflow also performs detached checkout and public smoke-tested deployment for the specified commit. ChangesDeployment workflow hardening
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/deploy-docs.yml:
- Around line 131-132: Update the cleanup steps in
.github/workflows/deploy-docs.yml lines 131-132 and
.github/workflows/deploy-production.yml lines 161-162 so GHCR credentials cannot
remain on the production server when a later SSH operation fails. Isolate Docker
credentials to the run-scoped deployment store, or make the registry login,
deployment, and logout steps a single transaction with cleanup guaranteed
regardless of intermediate SSH outcomes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: eb359570-a5fe-4eee-887e-92423298adf3
⛔ Files ignored due to path filters (3)
docs/increments/active/2026-07-28-public-docs-portal/plan.mdis excluded by!docs/**docs/increments/active/2026-07-28-public-docs-portal/verification.mdis excluded by!docs/**docs/runbooks/public-docs-deployment.mdis excluded by!docs/**
📒 Files selected for processing (2)
.github/workflows/deploy-docs.yml.github/workflows/deploy-production.yml
📜 Review details
⏰ Context from checks skipped due to timeout. (2)
- GitHub Check: Deployment contracts
- GitHub Check: Public docs · Node 24
🧰 Additional context used
📓 Path-based instructions (1)
.github/**/*.{yml,yaml}
⚙️ CodeRabbit configuration file
.github/**/*.{yml,yaml}: Require least-privilege permissions, explicit release tags for actions,
bounded job timeouts, concurrency cancellation, frozen lockfiles, and no
secrets in pull-request workflows. GitHub Actions are intentionally not
pinned to commit SHAs; Dependabot owns their scheduled version updates.
Files:
.github/workflows/deploy-production.yml.github/workflows/deploy-docs.yml
🧠 Learnings (1)
📚 Learning: 2026-07-24T22:52:57.466Z
Learnt from: kl3inIT
Repo: kl3inIT/OrgMemory PR: 40
File: .github/workflows/ci.yml:126-126
Timestamp: 2026-07-24T22:52:57.466Z
Learning: In this repository’s GitHub Actions workflows, the `uses:` field may intentionally reference GitHub Actions by explicit release tags (not immutable commit SHAs) per the project’s OrgMemory policy. Do not flag tag-based `uses:` references as “unpinned” if they are release-tag-based (e.g., `owner/repovX.Y.Z`) and follow the repo’s Dependabot-owned scheduled updates approach.
Applied to files:
.github/workflows/deploy-production.yml.github/workflows/deploy-docs.yml
🔇 Additional comments (2)
.github/workflows/deploy-docs.yml (1)
92-92: LGTM!Also applies to: 102-107, 119-129, 139-144
.github/workflows/deploy-production.yml (1)
119-119: LGTM!Also applies to: 129-134, 147-152, 169-174
Observed evidence
Automatic product deployment run 30399267433 timed out before SSH authentication. The deploy step was skipped, so no runtime mutation occurred. Cleanup then repeated the same two-minute timeout.
Change
Verification
This PR does not dispatch either deployment workflow.
Summary by CodeRabbit