chore: fail the lint run on a warning - #19
Merged
Conversation
`eslint src` exits zero on warnings, so a rule set to `warn` reported into the log and nothing stopped it accumulating. `--max-warnings 0` makes the lane say no. Nothing to clean up first: the run currently reports zero errors and zero warnings, so this changes no output today. What it changes is tomorrow — a rule that is deliberately a warning rather than an error now has to be dealt with rather than scrolled past. `lint:fix` is left alone. Adding the flag there would fail the run after fixing what it could, which is the opposite of what that script is for. Prettier deliberately not added. Formatting is the other half of "maximally strict", but introducing it now would reformat files wholesale and bury the next few diffs; that is a decision worth taking on its own. `vscode-ext-kit` has carried this flag for a while, so this brings the three extensions in line with it. Verified: lint, type check and the test suite. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eslint srcexits zero on warnings. A rule set towarnreported into thelog and nothing stopped it accumulating.
--max-warnings 0makes the lane say no.Nothing to clean up first
The run currently reports zero errors and zero warnings, so this changes no
output today. What it changes is tomorrow: a rule that is deliberately a warning
rather than an error now has to be dealt with rather than scrolled past.
What is deliberately not in here
lint:fixkeeps no flag. Adding it there would fail the run after fixingwhat it could, which is the opposite of what that script is for.
but introducing it now would reformat files wholesale and bury the next few
diffs. That is a decision worth taking on its own, not as a rider.
vscode-ext-kithas carried this flag for a while; this brings the threeextensions in line with it.
Verification
lint, the type check and the test suite.
🤖 Generated with Claude Code