Skip to content

fix: spawn the archiver without a shell in verify-vsix #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kkdev92 merged 1 commit into from
Aug 12, 2026
Merged

fix: spawn the archiver without a shell in verify-vsix #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions scripts/verify-vsix.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
* Usage: node scripts/verify-vsix.mjs [path-to.vsix]
*/

import { execSync } from 'node:child_process';
import { execFileSync } from 'node:child_process';
import { copyFileSync, existsSync, mkdirSync, readdirSync, readFileSync, rmSync } from 'node:fs';
import { join, resolve } from 'node:path';
import { fileURLToPath } from 'node:url';
Expand Down Expand Up @@ -98,11 +98,18 @@ function extract(vsixPath) {
// POSIX use unzip. Relative paths avoid bsdtar misparsing `C:\…` as a remote.
const localCopy = join(extractDir, 'package.vsix.zip');
copyFileSync(vsixPath, localCopy);
const command =
// Spawned with an argv array rather than a shell string, so the archiver's path
// is an argument instead of a word to be parsed. `SystemRoot` is a trusted value
// — anyone who can set it can already run anything — but as argv there is no
// quoting to get right and no shell to get it wrong.
const [command, args] =
process.platform === 'win32'
? `"${join(process.env.SystemRoot ?? 'C:\\Windows', 'System32', 'tar.exe')}" -xf package.vsix.zip`
: 'unzip -q package.vsix.zip';
execSync(command, { cwd: extractDir, stdio: 'inherit' });
? [
join(process.env.SystemRoot ?? 'C:\\Windows', 'System32', 'tar.exe'),
['-xf', 'package.vsix.zip'],
]
: ['unzip', ['-q', 'package.vsix.zip']];
execFileSync(command, args, { cwd: extractDir, stdio: 'inherit' });
rmSync(localCopy);
}

Expand Down