Respect KITOPS_HOME in library config path#1189
Open
puneetdixit200 wants to merge 4 commits into
Open
Conversation
Signed-off-by: Puneet Dixit <236133619+puneetdixit200@users.noreply.github.com>
amisevsk
requested changes
May 21, 2026
Signed-off-by: Puneet Dixit <236133619+puneetdixit200@users.noreply.github.com>
Signed-off-by: Puneet Dixit <236133619+puneetdixit200@users.noreply.github.com>
Signed-off-by: Puneet Dixit <236133619+puneetdixit200@users.noreply.github.com>
Author
|
Addressed in f401174. The root command now delegates the shared environment/default path resolution to |
Author
|
The duplicate lookup concern is addressed in the current head: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
constants.ConfigPath()so library callers can resolve the KitOps root storage directory with$KITOPS_HOMEsupport and the existing platform default fallback. The root command now delegates environment/default path resolution to that helper while preserving--configflag precedence.Regression coverage verifies both
$KITOPS_HOMEand default fallback behavior.Linked issues
Fixes #1171
AI-Assisted Code
Tests
GOMODCACHE=$PWD/.gomodcache GOCACHE=$PWD/.gocache go test ./pkg/lib/constantsGOMODCACHE=$PWD/.gomodcache GOCACHE=$PWD/.gocache go test ./pkg/lib/constants ./cmdgit diff --check