-
Notifications
You must be signed in to change notification settings - Fork 18
chore: bump Go to 1.27 and golangci-lint to v2.13.2 #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MrBeldum
wants to merge
3
commits into
kinbiko:main
Choose a base branch
from
MrBeldum:chore/bump-go-1.27
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,198 +1,201 @@ | ||
| run: | ||
| timeout: 1m | ||
|
|
||
| linters-settings: | ||
| errcheck: | ||
| # report about not checking of errors in type assetions: `a := b.(MyStruct)`; | ||
| # default is false: such cases aren't reported by default. | ||
| check-type-assertions: true | ||
|
|
||
| # report about assignment of errors to blank identifier: `num, _ := strconv.Atoi(numStr)`; | ||
| # default is false: such cases aren't reported by default. | ||
| check-blank: false | ||
|
|
||
| # [deprecated] comma-separated list of pairs of the form pkg:regex | ||
| # the regex is used to ignore names within pkg. (default "fmt:.*"). | ||
| # see https://github.com/kisielk/errcheck#the-deprecated-method for details | ||
| # ignore: fmt:.*,io/ioutil:^Read.* | ||
|
|
||
| # path to a file containing a list of functions to exclude from checking | ||
| # see https://github.com/kisielk/errcheck#excluding-functions for details | ||
| # exclude: /path/to/file.txt | ||
|
|
||
| funlen: | ||
| lines: 50 | ||
| statements: 40 | ||
|
|
||
| govet: | ||
| # report about shadowed variables | ||
| shadow: true | ||
|
|
||
| # enable or disable analyzers by name | ||
| # enable: | ||
| # - atomicalign | ||
| enable-all: true | ||
| disable: | ||
| - fieldalignment | ||
| # disable-all: false | ||
| revive: | ||
| # minimal confidence for issues, default is 0.8 | ||
| min-confidence: 0.8 | ||
| gofmt: | ||
| # simplify code: gofmt with `-s` option, true by default | ||
| simplify: true | ||
| goimports: | ||
| # put imports beginning with prefix after 3rd-party packages; | ||
| # it's a comma-separated list of prefixes | ||
| local-prefixes: github.com/kinbiko/bugsnag | ||
| gocyclo: | ||
| # minimal code complexity to report, 30 by default (but we recommend 10-20) | ||
| # This check is set to an unreasonably low number by most developers' | ||
| # standards to track the code standard over time | ||
| min-complexity: 10 | ||
| gocognit: | ||
| # minimal code complexity to report, 30 by default (but we recommend 10-20) | ||
| # This check is a more useful cyclomatic complexity called cognitive complexity, | ||
| # where nested if/for is weighted more, and only one point regardless of | ||
| # cases in a switch. | ||
| min-complexity: 11 | ||
| dupl: | ||
| # tokens count to trigger issue, 150 by default | ||
| threshold: 100 | ||
| goconst: | ||
| # minimal length of string constant, 3 by default | ||
| min-len: 10 | ||
| # minimal occurrences count to trigger, 3 by default | ||
| min-occurrences: 3 | ||
|
|
||
| # packages-with-error-messages: | ||
| # specify an error message to output when a blacklisted package is used | ||
| # github.com/sirupsen/logrus: "logging is allowed only by logutils.Log" | ||
| misspell: | ||
| # Correct spellings using locale preferences for US or UK. | ||
| # Default is to use a neutral variety of English. | ||
| # Setting locale to US will correct the British spelling of 'colour' to 'color'. | ||
| locale: US | ||
| # ignore-words: | ||
| # - someword | ||
| lll: | ||
| # max line length, lines longer will be reported. Default is 120. | ||
| # '\t' is counted as 1 character by default, and can be changed with the tab-width option | ||
| line-length: 165 | ||
| # tab width in spaces. Default to 1. | ||
| tab-width: 4 | ||
| unused: | ||
| # treat code as a program (not a library) and report unused exported identifiers; default is false. | ||
| # XXX: if you enable this setting, unused will report a lot of false-positives in text editors: | ||
| # if it's called for subdir of a project it can't find funcs usages. All text editor integrations | ||
| # with golangci-lint call it on a directory with the changed file. | ||
| check-exported: false | ||
| unparam: | ||
| # Inspect exported functions, default is false. Set to true if no external program/library imports your code. | ||
| # XXX: if you enable this setting, unparam will report a lot of false-positives in text editors: | ||
| # if it's called for subdir of a project it can't find external interfaces. All text editor integrations | ||
| # with golangci-lint call it on a directory with the changed file. | ||
| check-exported: true | ||
| nakedret: | ||
| # make an issue if func has more lines of code than this setting and it has naked returns; default is 30 | ||
| # Naked returns can go plop itself | ||
| max-func-lines: 0 | ||
| prealloc: | ||
| # XXX: we don't recommend using this linter before doing performance profiling. | ||
| # For most programs usage of prealloc will be a premature optimization. | ||
|
|
||
| # Report preallocation suggestions only on simple loops that have no returns/breaks/continues/gotos in them. | ||
| # True by default. | ||
| simple: true | ||
| range-loops: true # Report preallocation suggestions on range loops, true by default | ||
| for-loops: false # Report preallocation suggestions on for loops, false by default | ||
| gocritic: | ||
| # Which checks should be enabled; can't be combined with 'disabled-checks'; | ||
| # See https://go-critic.github.io/overview#checks-overview | ||
| # To check which checks are enabled run `GL_DEBUG=gocritic golangci-lint run` | ||
| # By default list of stable checks is used. | ||
| # enabled-checks: | ||
| # - badCond | ||
|
|
||
| # Which checks should be disabled; can't be combined with 'enabled-checks'; default is empty | ||
| # disabled-checks: | ||
|
|
||
| # Enable multiple checks by tags, run `GL_DEBUG=gocritic golangci-lint run` to see all tags and checks. | ||
| # Empty list by default. See https://github.com/go-critic/go-critic#usage -> section "Tags". | ||
| enabled-tags: | ||
| - diagnostic | ||
| - style | ||
| - performance | ||
|
|
||
| settings: # settings passed to gocritic | ||
| captLocal: # must be valid enabled check name | ||
| paramsOnly: true | ||
| rangeValCopy: | ||
| sizeThreshold: 64 | ||
| godox: | ||
| # report any comments starting with keywords, this is useful for TODO or FIXME comments that | ||
| # might be left in the code accidentally and should be resolved before merging | ||
| keywords: # default keywords are TODO, BUG, and FIXME, these can be overwritten by this setting | ||
| - TODO | ||
| - FIXME | ||
| dogsled: | ||
| # checks assignments with too many blank identifiers; default is 2 | ||
| max-blank-identifiers: 2 | ||
|
|
||
| whitespace: | ||
| multi-if: false # Enforces newlines (or comments) after every multi-line if statement | ||
| multi-func: false # Enforces newlines (or comments) after every multi-line function signature | ||
|
|
||
| version: "2" | ||
| linters: | ||
| enable: | ||
| - asasalint | ||
| - asciicheck | ||
| - bidichk | ||
| - bodyclose | ||
| - canonicalheader | ||
| - containedctx | ||
| - contextcheck | ||
| - copyloopvar | ||
| - cyclop | ||
| - decorder | ||
| - dogsled | ||
| - dupl | ||
| - durationcheck | ||
| - err113 | ||
| - errchkjson | ||
| - errname | ||
| - errorlint | ||
| - exhaustive | ||
| - exhaustruct_v5 | ||
| - exptostd | ||
| - fatcontext | ||
| - forbidigo | ||
| - forcetypeassert | ||
| - funlen | ||
| - ginkgolinter | ||
| - gocheckcompilerdirectives | ||
| - gochecknoglobals | ||
| - gochecknoinits | ||
| - gochecksumtype | ||
| - gocognit | ||
| - goconst | ||
| - gocritic | ||
| - gocyclo | ||
| - godox | ||
| - goheader | ||
| - gomoddirectives | ||
| - gomodguard_v2 | ||
| - goprintffuncname | ||
| - gosec | ||
| - gosmopolitan | ||
| - grouper | ||
| - iface | ||
| - importas | ||
| - inamedparam | ||
| - interfacebloat | ||
| - intrange | ||
| - ireturn | ||
| - lll | ||
| - loggercheck | ||
| - maintidx | ||
| - makezero | ||
| - mirror | ||
| - misspell | ||
| - mnd | ||
| - musttag | ||
| - nakedret | ||
| - nestif | ||
| - nilerr | ||
| - nilnesserr | ||
| - nilnil | ||
| - noctx | ||
| - nolintlint | ||
| - nonamedreturns | ||
| - nosprintfhostport | ||
| - paralleltest | ||
| - perfsprint | ||
| - prealloc | ||
| - predeclared | ||
| - promlinter | ||
| - protogetter | ||
| - reassign | ||
| - recvcheck | ||
| - revive | ||
| - rowserrcheck | ||
| - sloglint | ||
| - spancheck | ||
| - sqlclosecheck | ||
| - staticcheck | ||
| - tagalign | ||
| - tagliatelle | ||
| - testifylint | ||
| - testpackage | ||
| - tparallel | ||
| - unconvert | ||
| - unparam | ||
| - usestdlibvars | ||
| - wastedassign | ||
| - whitespace | ||
| - wrapcheck | ||
| - zerologlint | ||
| disable: | ||
| - wsl | ||
| - depguard | ||
| - godot | ||
| - nlreturn | ||
|
|
||
| - depguard | ||
|
|
||
| - gci # This conflicts with goimports | ||
| - varnamelen # This has too many false positives around indexes etc to be useful | ||
| presets: | ||
| - bugs | ||
| - complexity | ||
| - format | ||
| - performance | ||
| - style | ||
| - unused | ||
| fast: false | ||
|
|
||
| - varnamelen | ||
| - wsl | ||
| settings: | ||
| dogsled: | ||
| max-blank-identifiers: 2 | ||
| dupl: | ||
| threshold: 100 | ||
| errcheck: | ||
| check-type-assertions: true | ||
| check-blank: false | ||
| funlen: | ||
| lines: 50 | ||
| statements: 40 | ||
| gocognit: | ||
| min-complexity: 11 | ||
| goconst: | ||
| min-len: 10 | ||
| min-occurrences: 3 | ||
| gocritic: | ||
| enabled-tags: | ||
| - diagnostic | ||
| - style | ||
| - performance | ||
| settings: | ||
| captLocal: | ||
| paramsOnly: true | ||
| rangeValCopy: | ||
| sizeThreshold: 64 | ||
| gocyclo: | ||
| min-complexity: 10 | ||
| godox: | ||
| keywords: | ||
| - TODO | ||
| - FIXME | ||
| govet: | ||
| disable: | ||
| - fieldalignment | ||
| enable-all: true | ||
| lll: | ||
| line-length: 165 | ||
| tab-width: 4 | ||
| misspell: | ||
| locale: US | ||
| nakedret: | ||
| max-func-lines: 0 | ||
| prealloc: | ||
| simple: true | ||
| range-loops: true | ||
| for-loops: false | ||
| unparam: | ||
| check-exported: true | ||
| whitespace: | ||
| multi-if: false | ||
| multi-func: false | ||
| exclusions: | ||
| generated: lax | ||
| rules: | ||
| - linters: | ||
| - cyclop | ||
| - dupl | ||
| - errcheck | ||
| - errchkjson | ||
| - exhaustivestruct | ||
| - forbidigo | ||
| - funlen | ||
| - gocognit | ||
| - goconst | ||
| - gocyclo | ||
| - gosmopolitan | ||
| - lll | ||
| - maintidx | ||
| - mnd | ||
| - paralleltest | ||
| - staticcheck | ||
| - testpackage | ||
| - varnamelen | ||
| path: _test\.go | ||
| - linters: | ||
| - err113 | ||
| path: \.go | ||
| paths: | ||
| - third_party$ | ||
| - builtin$ | ||
| - examples$ | ||
| issues: | ||
| # Excluding configuration per-path, per-linter, per-text and per-source | ||
| exclude-rules: | ||
| # Exclude some linters from running on tests files. | ||
| - path: _test\.go | ||
| linters: | ||
| - cyclop | ||
| - dupl | ||
| - errcheck | ||
| - errchkjson | ||
| - exhaustivestruct | ||
| - forbidigo | ||
| - funlen | ||
| - gocognit | ||
| - gocyclo | ||
| - gomnd | ||
| - lll | ||
| - stylecheck | ||
| - testpackage | ||
| - varnamelen | ||
| - maintidx | ||
| - path: \.go | ||
| linters: | ||
| - err113 | ||
|
|
||
| # Independently from option `exclude` we use default exclude patterns, | ||
| # it can be disabled by this option. To list all | ||
| # excluded by default patterns execute `golangci-lint run --help`. | ||
| # Default value for this option is true. | ||
| exclude-use-default: false | ||
| # Maximum issues count per one linter. Set to 0 to disable. Default is 50. | ||
| max-issues-per-linter: 0 | ||
| # Maximum count of issues with the same text. Set to 0 to disable. Default is 3. | ||
| max-same-issues: 0 | ||
| formatters: | ||
| enable: | ||
| - gofmt | ||
| - gofumpt | ||
| - goimports | ||
| settings: | ||
| gofmt: | ||
| simplify: true | ||
| goimports: | ||
| local-prefixes: | ||
| - github.com/kinbiko/bugsnag | ||
| exclusions: | ||
| generated: lax | ||
| paths: | ||
| - third_party$ | ||
| - builtin$ | ||
| - examples$ | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ouch, this file is even longer than before. It should be possible, without making any rules any weaker (stronger + still passing is OK), to reduce this file down to quite a bit less than 100 lines of code.