Skip to content

Solving constructor type issue #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CarlosGamero merged 1 commit into from
Mar 16, 2026
Merged

Solving constructor type issue #415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions packages/metrics/lib/prometheus/metrics/message-error/PrometheusMessageErrorCounter.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ describe('PrometheusMessageErrorCounter', () => {
{
name: 'test_metric',
helpDescription: 'test description',
labelNames: ['errorReason'],
messageVersion: (metadata: ProcessedMessageMetadata<TestMessage>) => {
registeredMessages.push(metadata) // Mocking it to check if value is registered properly
return undefined
Expand Down Expand Up @@ -85,7 +84,6 @@ describe('PrometheusMessageErrorCounter', () => {
{
name: 'Test metric',
helpDescription: 'test description',
labelNames: ['errorReason'],
},
promClient,
)
Expand Down Expand Up @@ -120,7 +118,6 @@ describe('PrometheusMessageErrorCounter', () => {
{
name: 'Test metric',
helpDescription: 'test description',
labelNames: ['errorReason'],
},
promClient,
)
Expand Down Expand Up @@ -168,7 +165,6 @@ describe('PrometheusMessageErrorCounter', () => {
{
name: 'Test metric',
helpDescription: 'test description',
labelNames: ['errorReason'],
messageVersion: (metadata: ProcessedMessageMetadata<TestMessage>) =>
metadata.message?.metadata?.schemaVersion,
},
Expand Down
9 changes: 9 additions & 0 deletions packages/metrics/lib/prometheus/metrics/message-error/PrometheusMessageErrorCounter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,19 @@
import type { ProcessedMessageMetadata } from '@message-queue-toolkit/core'
import type promClient from 'prom-client'
import type { LabelValues } from 'prom-client'
import type { PrometheusMetricParams } from '../../types.ts'
import { PrometheusMessageCounter } from './PrometheusMessageCounter.ts'

export class PrometheusMessageErrorCounter<
MessagePayload extends object,
> extends PrometheusMessageCounter<MessagePayload, 'errorReason'> {
constructor(
metricParams: Omit<PrometheusMetricParams<MessagePayload, 'errorReason'>, 'labelNames'>,
client: typeof promClient,
) {
super({ ...metricParams, labelNames: ['errorReason'] }, client)
}

protected override getLabelValuesForProcessedMessage(
metadata: ProcessedMessageMetadata<MessagePayload>,
): LabelValues<'errorReason'> {
Expand Down
Loading