Add ability to customize download title, content text, button text #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longnguyen245
commented
Jun 22, 2025
longnguyen245
commented
- The changes do not change the original logic at all and are fully compatible (New options are completely optional)
- Added ability to change titles for download statuses (downloading, successful, failed,...), as well as content text. It is also possible to customize how download progress is displayed
- Buttons (Cancel, resume,...) on notifications are customizable (better multilingual support)
- Change the display unit to Megabyte instead of Megabit (original code is calculating Megabyte but is displaying as Megabit)
…button text (this helps with multi-language support instead of hardcoding)
… instead of only being able to show 1 icon for all
…tionSmallIconConfig
…callback here because in original code it needs to be saved to DB, so will use template string"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.