🔧 fix: add explicit types to server tsconfig for Docker compatibility

[neopilotai]

Thinking Path

• Taskcore orchestrates AI agents for zero-human companies
• [Which subsystem or capability is involved]
• [What problem or gap exists]
• [Why it needs to be addressed]
• This pull request ...
• The benefit is ...

What Changed

Verification

Risks

For core feature work, check ROADMAP.md first and discuss it in #dev before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See CONTRIBUTING.md.

Model Used

Checklist

• I have included a thinking path that traces from project context to this change
• I have specified the model used (with version and capability details)
• I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work
• I have run tests locally and they pass
• I have added or updated tests where applicable
• If this change affects the UI, I have included before/after screenshots
• I have updated relevant documentation to reflect my changes
• I have considered and documented any risks above
• I will address all Greptile and reviewer comments before requesting merge

Summary by CodeRabbit

• Chores
  • Updated TypeScript compiler configuration to explicitly specify type packages, improving type checking consistency across the project's dependencies.

[qodo-code-review]

Review Summary by Qodo

Add explicit types to server tsconfig for Docker

🐞 Bug fix

Walkthroughs

Description

• Add explicit TypeScript types array to server tsconfig
• Ensures Docker build compatibility with type definitions
• Includes express, node, ws, multer, jsdom, supertest types

Diagram

flowchart LR
  A["server/tsconfig.json"] -- "add types array" --> B["Explicit type definitions"]
  B -- "includes" --> C["express, node, ws, multer, jsdom, supertest"]
  C -- "enables" --> D["Docker build compatibility"]

Loading

File Changes

1. server/tsconfig.json 🐞 Bug fix +2/-1

Add explicit types array to tsconfig

• Added explicit types array to TypeScript compiler options
• Includes type definitions for express, express-serve-static-core, node, ws, multer, jsdom, and
 supertest
• Ensures proper type resolution in Docker build environment

server/tsconfig.json

---

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📎 Requirement gaps (0)

1. Test types in build 🐞 Bug ☼ Reliability

Description

server/tsconfig.json now explicitly includes the supertest type package, which makes TypeScript
load @types/supertest for normal server builds even though src/__tests__ is excluded from this
tsconfig. This adds an unnecessary build-time dependency on test-only typings and can break builds
in environments where devDependencies aren’t installed.

Code

server/tsconfig.json[6]

+    "types": ["express", "express-serve-static-core", "node", "ws", "multer", "jsdom", "supertest"]

Evidence

The server tsconfig explicitly lists supertest in compilerOptions.types, but the same tsconfig
excludes src/__tests__ (where supertest is imported). Additionally, @types/supertest is a
devDependency, so requiring it during regular builds is avoidable and fragile when devDependencies
are not present.

server/tsconfig.json[1-10]
server/package.json[79-94]
server/src/tests/auth-routes.test.ts[1-4]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
`server/tsconfig.json` includes `"supertest"` in `compilerOptions.types`, which forces TypeScript to load `@types/supertest` during normal server builds despite tests being excluded from this project config.

### Issue Context
`supertest` typings are dev-only and primarily relevant to test compilation. Keeping them in the server build tsconfig adds an avoidable build-time requirement.

### Fix Focus Areas
- server/tsconfig.json[1-10]

### Suggested change
- Remove `"supertest"` from the `compilerOptions.types` list.
- (Optional) If you want explicit test typings, introduce a separate `tsconfig.test.json` that includes `src/__tests__` and adds `supertest`/`vitest` types there.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

[coderabbitai]

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

Updated TypeScript compiler configuration in server/tsconfig.json to explicitly enumerate type packages including express, node, ws, multer, jsdom, and supertest, replacing an implicit type resolution strategy with an explicit allowlist.

Changes

Cohort / File(s)	Summary
TypeScript Configuration server/tsconfig.json	Added explicit compilerOptions.types array specifying type packages for express, node, ws, multer, jsdom, and supertest to replace implicit type resolution.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Types declared with gentle care,
Express, Node, WebSocket fair,
No more mystery in the air—
Configuration now laid bare! 📝✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding explicit types to server tsconfig. However, it includes an emoji and claims Docker compatibility as motivation, which is not directly evident from the file change alone.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}