Shop room: readable text in Foundry, and Chronicle's current room - #168
Merged
Merged
Conversation
Foundry's theme defines some of Chronicle's colour variable names for its own palette but not the panel ones, so the room showed light text on its white fallback panels. The window and the widget's tooltip, bubble and picker now pin Chronicle's light palette. The vendored widget is copied again from Chronicle main. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JRAx4Ex5fEHkxVB5Yaqw86
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: none (Key Maker's report: the text in the Foundry shop room is unreadable because of its colours)
Security implication: none. CSS and a vendored widget copy only.
Consumer-verified: n/a
Mockup: n/a. This is an "it works again" fix: the room's text and panels now look as they do on the Chronicle shop page. The widget refresh brings in Chronicle's shop room from keyxmakerx/Chronicle#1093, which was signed on the Chronicle side.
What this changes
Before: in Foundry the shop room's text was hard or impossible to read. Labels, prices and the basket showed pale text on white panels.
After: the room uses Chronicle's own light colours, so the text reads the same as on the Chronicle shop page. This covers the hover tooltip, the speech bubble and the character picker too.
Why it happened
The widget colours itself from Chronicle's theme variables, such as
--color-text-primaryand--color-card-bg, with light fallbacks. Foundry's own theme defines some of those same names for its own palette, including the text ones, but not the panel ones. In Foundry the text therefore took Foundry's light theme text colour, while the panels fell back to white.How
styles/chronicle-sync.css:.chronicle-shop-roomand the widget's body-level.shr-tip,.shr-sayand.shr-pickpin Chronicle's light palette. The values are Chronicle's:rootlight values, which are also the widget's own fallbacks.vendor/chronicle/shop_room.js: copied again from Chronicle main 5580c08, which includes #1093.shop_room_icons.jsis unchanged.Test plan
CHRONICLE_DIR=../Chronicle node --test tools/test-*.mjs, with Chronicle at main 5580c08: 1174 pass, 0 fail. On module main without this change, the vendored-copy comparison fails, so the run is 1173 pass, 1 fail.Tenet self-check
Generated by Claude Code