Conversation
… auto-switch When the user taps the "Choose keyboard" menu item on the home screen and the automatic keyboard switching feature is enabled, show a dialog warning that auto-switch will be disabled. If the user confirms, the feature is turned off and the IME picker is opened. This prevents KeyMapper immediately and silently switching back to its own IME after the user has deliberately selected another keyboard. https://claude.ai/code/session_01AdijnJnpbsCqPDTYobwnLa
…eCase Move isAutoSwitchImeEnabled flow and disableAutoSwitch() out of FixKeyEventActionDelegate (where they don't belong) and into ShowInputMethodPickerUseCase which owns all IME picker concerns. KeyMapListViewModel now reads/writes through the use case. https://claude.ai/code/session_01AdijnJnpbsCqPDTYobwnLa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2106
Summary
This prevents the confusing experience where a user manually selects a keyboard from the IME picker, only to have KeyMapper immediately switch back to its own IME via the auto-switch feature.
Changes
FixKeyEventActionDelegate.ktisAutoSwitchImeEnabled: Flow<Boolean>to the interface and implementation, reading from thechangeImeOnInputFocuspreferenceKeyMapListViewModel.ktshowInputMethodPicker()now launches a coroutine, checks whether auto-switch is on, shows the confirmation dialog if so, disables the feature on confirm, then shows the IME pickerstrings.xmldialog_title_disable_auto_switch_imeanddialog_message_disable_auto_switch_imestringshttps://claude.ai/code/session_01AdijnJnpbsCqPDTYobwnLa