Misc2 #1352
Open
Misc2 #1352
+439
−400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattiaswal
force-pushed
the
misc2
branch
2 times, most recently
from
7810829 to
a580e3e
Compare
troglobit
requested changes
Jan 14, 2026
Contributor
troglobit
left a comment
troglobit
left a comment
There was a problem hiding this comment.
Nice work! Only a suggestion for the mobility-domain type.
mattiaswal
force-pushed
the
misc2
branch
4 times, most recently
from
e902ddb to
83d6849
Compare
…terface Then hostapd needs to be restarted, handle this by adding the wifi container to the diff if a custom-phys-address has been changed on a Wi-Fi interface.
hostname can work, but from startup it does not, wg setconf fails and with that dagger.
Use the standard name instead of the marketing name, new syntax enable-80211ax, which is consistent with the nameing of the new roaming settings.
enable-reflector should be set to yes or no, not on off according to manpage.
The firmware seems to keep states when have been configured as an AP then change to be a station.
mattiaswal
force-pushed
the
misc2
branch
2 times, most recently
from
4108a78 to
8eed911
Compare
This is run per interface, not per radio so its place in hardware.c was wrong. This also opens up for multiple station interfaces per radio, but not for now that it locked down in a must expression for now.
…radio This since this is 99% of the cases wrong config, and crashes on many Wi-Fi chipset.
Happened when adding a second station interface (only supports one), was lacking a check for a nullpointer.
This is obsolete. By remove this we expose radio as mandatory. This since a Wi-Fi interface is not possible to create without a radio to connect it to.
This reverts commit bf1eca0. This mess up order if having more than 1 phy, have not been reproduce the error that got me to introduce this fix from the beginning.
When migrate to 1.7 the keystore was not correctly migrated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Misc fixes (mostly wifi)
this PR initially contained roaming, removed it. and put it on a seperate branch: wifi-roaming
Tested on BPI-r3 and RPI4
Description
Checklist
Tick relevant boxes, this PR is-a or has-a: