feat: multi-select table status filters - #2125
alanpeixinho merged 4 commits into
Conversation
|
| <div className="ml-auto"> | ||
| <div className="flex justify-end"> | ||
| <TableGroupingControls {...groupingControls} /> | ||
| </div> |
There was a problem hiding this comment.
this used to sit on the same row as the filters (ml-auto). now it's always on a second row, even on wide screens.
the mobile wrap makes sense, but on desktop the grouping controls jumping down looks like a regression. can we keep them on the first row when there's space?
There was a problem hiding this comment.
Good catch, that was the first version. The grouping controls now stay on the first row: the container is sm:flex-row sm:flex-wrap with sm:ml-auto on the controls, so they only wrap when there is genuinely no space.
Pushed one more commit on top: the status filter and search are now wrapped in a contents sm:flex cluster, so on wide screens they behave as a single item (search never splits away from the pills) while on small screens contents keeps them as direct flex children, letting search stay order-last right above the table.
* Multi-select success/failed/inconclusive pills with shared FilterButton styling * All control toggles full selection or clears every status filter * Persist tableFilter as URL arrays with minify support and legacy query compatibility * Apply filters across builds, boots, and tests tables and related detail pages * Improve TableTopFilters layout for narrow viewports Closes kernelci#1428 Signed-off-by: Alan Peixinho <alan.peixinho@profusion.mobi>
* Drop the All chip; junk URL values fall back to the default selection * Share pill styling: FilterButton for toggles, PillButton for grouping actions * Keep grouping on the first row; on mobile order status, grouping, then search * Pass resetScroll: false so status chips do not jump the page
d7019e2 to
1a5732a
Compare
Wrap the status filter and search in a display: contents cluster so the grouping controls stay on the first row and search keeps sitting right above the table on small screens. Signed-off-by: Alan Peixinho <alan.peixinho@profusion.mobi>
The contents/sm:flex classes already show the breakpoint split. Signed-off-by: Alan Peixinho <alan.peixinho@profusion.mobi>
2 participants
What it is
Replaces single-value table status filters with multi-select pills (success / failed / inconclusive) on builds, boots, and tests tables and related build/issue detail views. Adds an All control (full selection or clear), shared FilterButton styling, and URL
tableFilterarrays with legacy query support. Improves TableTopFilters layout on narrow viewports.Closes #1428
How to test
tfparams round-trip.Made with Cursor