Skip to content

Fix: tests table height - #2026

Open
MarceloRobert wants to merge 1 commit into
kernelci:mainfrom
MarceloRobert:fix/tests-table-height
Open

Fix: tests table height#2026
MarceloRobert wants to merge 1 commit into
kernelci:mainfrom
MarceloRobert:fix/tests-table-height

Conversation

@MarceloRobert

Copy link
Copy Markdown
Contributor

Summary

Replaces static height with a max limit on individual tests table, allowing tables with less data to be shorter

Changes

  • Replaces static table height with max-h
  • Replaces static px with tailwind's size

How to test

  • Go to a page that has the individual tests table (treeDetails/hardwareDetails tests tab, buildDetails, issueDetails) and has only a few tests.
  • Check that the table doesn't have whitespace at the bottom but still allows for scrolling on other pages when it has a lot of tests.
  • Compare with the original

Visual Examples

Before / After:

image image

Test with staging environment: https://staging.dashboard.kernelci.org/issue/redhat%3Aissue_2504?iv=1774001989&o=redhat

Closes #2025

Replaces static height with a max limit, allowing tables with less data to be shorter

Closes kernelci#2025

Signed-off-by: Marcelo Robert Santos <4mrSantos@gmail.com>
@MarceloRobert

Copy link
Copy Markdown
Contributor Author

@mentonin about the tests, I don't think that adding e2e tests is the right choice here. As I see, e2e tests are made to test behavior, not layout; there's also not a specific "tests table page", we would need to test something like "build details with tests" before specifying the table.
For layout tests it would be best to have a snapshot-based testing, which Playwright (the currently used e2e test library) can provide, but I'm unsure if that would even be useful in this case since the changes are not complex at all

@mentonin

Copy link
Copy Markdown
Contributor

I don't think that adding e2e tests is the right choice here

I am fine with that

@alanpeixinho alanpeixinho left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Individual tests table is too tall when there are only a few tests

3 participants