feat: Using stable key on tree lists on Hardware Details Page#1919
Open
alanpeixinho wants to merge 1 commit into
Open
feat: Using stable key on tree lists on Hardware Details Page#1919alanpeixinho wants to merge 1 commit into
alanpeixinho wants to merge 1 commit into
Conversation
d6e30c2 to
7ad281b
Compare
* Use a hash key from git_url, tree_name and branch to be sure we can
select trees, without need of compatible ordering between frontend
and backend.
Closes kernelci#1909
Signed-off-by: Alan Peixinho <alan.peixinho@profusion.mobi>
7ad281b to
52b19d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it is
Changes the default selection tree of hardware details page, from using index based selection, to a stable (hash based) selection.
How to test
?x[]=[0,1]Closes #1909