feat: implement fallback when tree_tests_rollup doesn't have data#1853
Open
gustavobtflores wants to merge 1 commit intokernelci:mainfrom
Open
feat: implement fallback when tree_tests_rollup doesn't have data#1853gustavobtflores wants to merge 1 commit intokernelci:mainfrom
gustavobtflores wants to merge 1 commit intokernelci:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a safety-net in the tree details summary endpoint so it can still return boot/test summary data when the pre-aggregated tree_tests_rollup table hasn’t been populated yet for a given checkout.
Changes:
- Introduces a rollup-empty detection in
BaseTreeDetailsSummary.get()and falls back to the legacyget_tree_details_data()query. - Adds
_sanitize_test_rows_legacy()to compute boot/test summaries from legacy rows (while builds are still handled by the builds-specific query). - Logs when the fallback path is triggered to aid debugging.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
75c5d36 to
eee2dd1
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds fallback logic to treeDetailsSummaryView to handle cases where the pre-aggregated tree_tests_rollup table has not yet been populated for a checkout. When rollup data is empty, the endpoint now falls back to the legacy row-by-row query approach to ensure test/boot summary data is still returned.
Changes