Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
actions/create-github-app-tokencalled without anypermission-*inputs mints a token carrying every permission the app installation holds, including administration and workflows write. This PR requests only what each token is used for downstream. Repository scope is unchanged unless noted.vuln-remediation.ymlscancontents: readactions/checkoutThis one matters more than most. Checkout persists the token in
.git/config, and the same job then runsnpm install -g @socketsecurity/cliand the Socket scan. Every repo that calls this reusable workflow gave that third-party code a token with admin and workflow write on its own repo. Thefixandprtokens in this workflow already had permission filters and are unchanged.That checkout now also sets
persist-credentials: false, so the token isn't left in.git/configwhile the Socket CLI installs and runs. The scan reads the local tree and never uses git credentials.Testing
python3 -m unittest discover -s scripts -p test_vuln_remediation_workflow.py: 20 OK.actionlint: no findings.