Skip to content

Document that vault fill selectors must be unique - #270

Merged
rgarcia merged 1 commit into
mainfrom
hypeship/vault-fill-unique-selectors
Nov 9, 2026
Merged

rgarcia merged 1 commit into
mainfrom
hypeship/vault-fill-unique-selectors

Conversation

@rgarcia

@rgarcia rgarcia commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Vault fill rejects a binding whose selector matches more than one element across the page and its iframes, returning ambiguous_selector without writing anything. Hosted card-field iframes such as Shopify checkout's each contain hidden decoy inputs with the same name as the real field. As a result, input[name='number'] fails even though only one input is visible. The manage_vault_items inputs description told agents to target the input inside nested iframes but didn't mention that selectors must be unique, so agents reached for name selectors and the first fill failed.

This adds one sentence to that description: each selector must match exactly one element across frames, and a hidden duplicate is common in payment iframes, so select by an attribute only the visible input has. On Shopify, for example, input[data-current-field='number'] matches only the visible input.

Testing

  • Changes only the tool description string. No behavior change, so no new tests.
  • bun test: 1139 pass, 0 fail. tsc --noEmit is clean. Prettier check passes on the changed file.
  • The selector behavior was observed on a real Shopify checkout: name selectors returned ambiguous_selector, and data-current-field selectors filled all three fields.

@vercel

vercel Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
mcp Ready Ready Preview Nov 9, 2026 6:10pm UTC

@rgarcia
rgarcia merged commit 9e45b8a into main Nov 9, 2026
10 checks passed
@rgarcia
rgarcia deleted the hypeship/vault-fill-unique-selectors branch November 9, 2026 21:26

This branch was successfully deployed

1 active deployment
Preview — 3d06a4bc Deployed Nov 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants