Repository navigation
Document that vault fill selectors must be unique - #270
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
hiroTamada
approved these changes
Nov 9, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Vault
fillrejects a binding whose selector matches more than one element across the page and its iframes, returningambiguous_selectorwithout writing anything. Hosted card-field iframes such as Shopify checkout's each contain hidden decoy inputs with the samenameas the real field. As a result,input[name='number']fails even though only one input is visible. Themanage_vault_itemsinputsdescription told agents to target the input inside nested iframes but didn't mention that selectors must be unique, so agents reached fornameselectors and the first fill failed.This adds one sentence to that description: each selector must match exactly one element across frames, and a hidden duplicate is common in payment iframes, so select by an attribute only the visible input has. On Shopify, for example,
input[data-current-field='number']matches only the visible input.Testing
bun test: 1139 pass, 0 fail.tsc --noEmitis clean. Prettier check passes on the changed file.nameselectors returnedambiguous_selector, anddata-current-fieldselectors filled all three fields.