Skip to content

Use federated model credentials instead of static LLM API keys - #269

Merged
rgarcia merged 1 commit into
mainfrom
hypeship/llm-credentials-action
Nov 9, 2026
Merged

rgarcia merged 1 commit into
mainfrom
hypeship/llm-credentials-action

Conversation

@rgarcia

@rgarcia rgarcia commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Part of removing the static ANTHROPIC_API_KEY / OPENAI_API_KEY org secrets from GitHub Actions. The shared workflows in kernel/security-workflows are moving to its llm-credentials composite action (documented in that repo's README, "llm-credentials action"), which exchanges the job's GitHub OIDC token for short-lived model credentials through workload identity federation. That requires the calling workflow to grant id-token: write.

  • .github/workflows/semgrep.yml: add id-token: write to the top-level permissions: block (existing entries kept), with a one-line comment.
  • .github/workflows/vuln-remediation.yml: add id-token: write to the top-level permissions: block (existing entries kept), with a one-line comment.

Neither file references the API key secrets directly; both pass secrets via secrets: inherit, so nothing else changes.

Safe to merge now

The new permission is unused until kernel/security-workflows switches semgrep.yml and vuln-remediation.yml to the action, and that change merges only after every caller has the permission.

Testing

  • actionlint 1.7.7 (release tarball, sha256 verified) with shellcheck 0.10.0 on PATH, run on both changed workflows: 0 errors.
  • rg -n 'ANTHROPIC_API_KEY|OPENAI_API_KEY' .github: no matches.
  • No workflow was run live.

@vercel

vercel Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
mcp Ready Ready Preview Nov 9, 2026 4:54pm UTC

@rgarcia

rgarcia commented Nov 9, 2026

Copy link
Copy Markdown
Contributor Author

Picked ulziibay-kernel to review: touched the changed code in workflows; 33 pending

@rgarcia
rgarcia requested review from JonnyShuali and removed request for ulziibay-kernel November 9, 2026 21:36
@rgarcia

rgarcia commented Nov 9, 2026

Copy link
Copy Markdown
Contributor Author

Picked JonnyShuali to review: these caller changes only add id-token: write, and he reviewed the llm-credentials action (security-workflows#36, #39); moved off ulziibay-kernel, who has 27 pending

@rgarcia
rgarcia merged commit 8871b9d into main Nov 9, 2026
10 checks passed
@rgarcia
rgarcia deleted the hypeship/llm-credentials-action branch November 9, 2026 22:17

This branch was successfully deployed

1 active deployment
Preview — a2479ff8 Deployed Nov 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants