fix(chromium-headful): refocus live view on mouse down - #337
Open
masnwilliams wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
why
The overlay prevents the browser's default mouse-down behavior. If focus moves elsewhere while the pointer remains over the video,
mouseenterdoes not fire again and clicking the video cannot restore focus. Subsequent keyboard events are delivered to the previously focused control instead of the remote browser.validation
textarea.overlayand the remote field receivedabcmousedown,mouseup, andclickdelivery still worksAbc1\nbun run lint(0 errors; existing warnings)bun run build(passes; existing lint and bundle-size warnings)The client does not currently have an automated component test suite for this interaction.
Note
Low Risk
Single guarded focus call in the live-view mouse handler; no auth, data, or API changes.
Overview
Fixes desktop live-view keyboard capture when focus has drifted off the overlay while the pointer is still over the video.
After the existing hosting and lock checks in
onMouseDown, non-touch sessions now callfocus()on the overlay textarea before forwarding mouse position and remotemousedown. Touch devices are unchanged so mobile keyboard behavior stays the same.This addresses a case where
mouseenterdoes not run again after focus moves elsewhere, so clicks on the video did not restore focus and keystrokes went to the wrong control.Reviewed by Cursor Bugbot for commit 7adc04c. Bugbot is set up for automated code reviews on this repo. Configure here.